Skip to content

fix(material-renderers): add missing Mui-error class for some controls#2433

Merged
lucas-koehler merged 2 commits into
eclipsesource:masterfrom
vishnutsivan:master
Apr 8, 2025
Merged

fix(material-renderers): add missing Mui-error class for some controls#2433
lucas-koehler merged 2 commits into
eclipsesource:masterfrom
vishnutsivan:master

Conversation

@vishnutsivan
Copy link
Copy Markdown
Contributor

@vishnutsivan vishnutsivan commented Apr 4, 2025 •
edited
Loading

  • Passing error prop for missing controls

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 4, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 4, 2025 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 9f53777
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/67f5073bb65c3a00098fa873
😎 Deploy Preview https://deploy-preview-2433--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 8, 2025 •
edited
Loading

Coverage Status

coverage: 82.517%. remained the same
when pulling 9f53777 on vishnutsivan:master
into 9acd631 on eclipsesource:master.

lucas-koehler
lucas-koehler requested changes Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution aligning this with the other controls ❤️

Please remove the version update as explained inline :)

Comment thread packages/material-renderers/package.json Outdated
{
"name": "@jsonforms/material-renderers",
"version": "3.5.1",
"version": "3.5.2",
Copy link
Copy Markdown
Contributor

@lucas-koehler lucas-koehler Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. Version numbers are automatically increased when we release a new version via CI

Copy link
Copy Markdown
Contributor Author

@vishnutsivan vishnutsivan Apr 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted. when can we expect new version?

lucas-koehler
lucas-koehler approved these changes Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnutsivan Thanks for the update! This LGTM now.

The next regular release will probably be around end of May or in June. There is no fixed date, yet. However, we could do a pre-release (e.g. 3.6.0-alpha.0) this week.

@lucas-koehler lucas-koehler merged commit 28f36ed into eclipsesource:master Apr 8, 2025
8 checks passed
@lucas-koehler lucas-koehler added this to the 3.6 milestone Apr 8, 2025
@lucas-koehler
Copy link
Copy Markdown
Contributor

lucas-koehler commented Apr 10, 2025 •
edited
Loading

@vishnutsivan I published version 3.6.0-alpha.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-koehler lucas-koehler lucas-koehler approved these changes

Assignees

No one assigned

Labels

material react

Projects

None yet

Milestone

3.6

Development

Successfully merging this pull request may close these issues.

4 participants

@vishnutsivan @CLAassistant @coveralls @lucas-koehler